-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed cypress tests. #1027
Merged
amsiglan
merged 1 commit into
opensearch-project:main
from
AWSHurneyt:3.0-v2.16-cypress-fixes
Jul 30, 2024
Merged
Fixed cypress tests. #1027
amsiglan
merged 1 commit into
opensearch-project:main
from
AWSHurneyt:3.0-v2.16-cypress-fixes
Jul 30, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: AWSHurneyt <[email protected]>
AWSHurneyt
requested review from
lezzago,
amsiglan,
sbcd90,
eirsep,
getsaurabh02,
praveensameneni,
bowenlan-amzn,
rishabhmaurya and
riysaxen-amzn
as code owners
July 29, 2024 20:14
1 task
riysaxen-amzn
approved these changes
Jul 30, 2024
amsiglan
approved these changes
Jul 30, 2024
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 370cad8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 370cad8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 370cad8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 370cad8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot
pushed a commit
that referenced
this pull request
Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]> (cherry picked from commit 370cad8) Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Jul 30, 2024
(cherry picked from commit 370cad8) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn
pushed a commit
that referenced
this pull request
Jul 30, 2024
(cherry picked from commit 370cad8) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
74 tasks
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 9, 2025
(cherry picked from commit 370cad8) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
The backport to
To backport manually, run these commands in your terminal: # Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.15
# Create a new branch
git switch --create backport-1027-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 370cad8d8442bebd0e6e181a3de60f3ab278c208
# Push it to GitHub
git push --set-upstream origin backport-1027-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.15 Then, create a pull request where the |
vikhy-aws
pushed a commit
to vikhy-aws/alerting-dashboards-plugin
that referenced
this pull request
Jan 9, 2025
(cherry picked from commit 370cad8) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt
pushed a commit
that referenced
this pull request
Jan 10, 2025
…ge preview (#1183) (#1185) * [BUG] Change time format to UTC in notification message preview (#1183) * fix: change notification preview message to have time in UTC format. fix an improper import Signed-off-by: vikhy-aws <[email protected]> * fix: add unit tests. change timezone to UTC Signed-off-by: vikhy-aws <[email protected]> * fix: remove log statements Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for loadSampleEcommerceData to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: update timeout for monitor creation to 60secs to handle failing cypress test Signed-off-by: vikhy-aws <[email protected]> * fix: revert timeout increases. Handle monitors page load properly. Signed-off-by: vikhy-aws <[email protected]> * fix: revert changes to timeouts Signed-off-by: vikhy-aws <[email protected]> * fix: increase timeouts to ensure proper loading of pages Signed-off-by: vikhy-aws <[email protected]> --------- Signed-off-by: vikhy-aws <[email protected]> * fix: update upload-artifact version to v4. v1 is deprecated. Signed-off-by: vikhy-aws <[email protected]> * fix: update cypress workflow to use apt versions of dashboard and plugin Signed-off-by: vikhy-aws <[email protected]> * update cypress workflow Signed-off-by: vikhy-aws <[email protected]> * Fixed cypress tests. (#1027) (#1032) (cherry picked from commit 370cad8) Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> --------- Signed-off-by: vikhy-aws <[email protected]> Signed-off-by: AWSHurneyt <[email protected]> Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com> Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed cypress tests following PR opensearch-project/alerting#1612
Issues Resolved
[List any issues this PR will resolve]
Check List
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.