Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed cypress tests. #1027

Merged

Conversation

AWSHurneyt
Copy link
Collaborator

Description

Fixed cypress tests following PR opensearch-project/alerting#1612

Issues Resolved

[List any issues this PR will resolve]

Check List

  • New functionality includes testing.
    • All tests pass
  • New functionality has been documented.
    • New functionality has javadoc added
  • Commits are signed per the DCO using --signoff

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.

Signed-off-by: AWSHurneyt <[email protected]>
@amsiglan amsiglan merged commit 370cad8 into opensearch-project:main Jul 30, 2024
14 of 19 checks passed
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 370cad8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 370cad8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 370cad8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 370cad8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
opensearch-trigger-bot bot pushed a commit that referenced this pull request Jul 30, 2024
Signed-off-by: AWSHurneyt <[email protected]>
(cherry picked from commit 370cad8)
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Jul 30, 2024
(cherry picked from commit 370cad8)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
riysaxen-amzn pushed a commit that referenced this pull request Jul 30, 2024
(cherry picked from commit 370cad8)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Jan 9, 2025
(cherry picked from commit 370cad8)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@opensearch-trigger-bot
Copy link
Contributor

The backport to 2.15 failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Navigate to the root of your repository
cd $(git rev-parse --show-toplevel)
# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add ../.worktrees/alerting-dashboards-plugin/backport-2.15 2.15
# Navigate to the new working tree
pushd ../.worktrees/alerting-dashboards-plugin/backport-2.15
# Create a new branch
git switch --create backport-1027-to-2.15
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 370cad8d8442bebd0e6e181a3de60f3ab278c208
# Push it to GitHub
git push --set-upstream origin backport-1027-to-2.15
# Go back to the original working tree
popd
# Delete the working tree
git worktree remove ../.worktrees/alerting-dashboards-plugin/backport-2.15

Then, create a pull request where the base branch is 2.15 and the compare/head branch is backport-1027-to-2.15.

vikhy-aws pushed a commit to vikhy-aws/alerting-dashboards-plugin that referenced this pull request Jan 9, 2025
(cherry picked from commit 370cad8)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
AWSHurneyt pushed a commit that referenced this pull request Jan 10, 2025
…ge preview (#1183) (#1185)

* [BUG] Change time format to UTC in notification message preview (#1183)

* fix: change notification preview message to have time in UTC format. fix an improper import

Signed-off-by: vikhy-aws <[email protected]>

* fix: add unit tests. change timezone to UTC

Signed-off-by: vikhy-aws <[email protected]>

* fix: remove log statements

Signed-off-by: vikhy-aws <[email protected]>

* fix: update timeout for loadSampleEcommerceData to 60secs to handle failing cypress test

Signed-off-by: vikhy-aws <[email protected]>

* fix: update timeout for monitor creation to 60secs to handle failing cypress test

Signed-off-by: vikhy-aws <[email protected]>

* fix: update timeout for monitor creation to 60secs to handle failing cypress test

Signed-off-by: vikhy-aws <[email protected]>

* fix: revert timeout increases. Handle monitors page load properly.

Signed-off-by: vikhy-aws <[email protected]>

* fix: revert changes to timeouts

Signed-off-by: vikhy-aws <[email protected]>

* fix: increase timeouts to ensure proper loading of pages

Signed-off-by: vikhy-aws <[email protected]>

---------

Signed-off-by: vikhy-aws <[email protected]>

* fix: update upload-artifact version to v4. v1 is deprecated.

Signed-off-by: vikhy-aws <[email protected]>

* fix: update cypress workflow to use apt versions of dashboard and plugin

Signed-off-by: vikhy-aws <[email protected]>

* update cypress workflow

Signed-off-by: vikhy-aws <[email protected]>

* Fixed cypress tests. (#1027) (#1032)

(cherry picked from commit 370cad8)

Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

---------

Signed-off-by: vikhy-aws <[email protected]>
Signed-off-by: AWSHurneyt <[email protected]>
Signed-off-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: opensearch-trigger-bot[bot] <98922864+opensearch-trigger-bot[bot]@users.noreply.github.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants